-
Notifications
You must be signed in to change notification settings - Fork 0
fix(279): avoid leaking sanitization error payloads #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # Sanitization Error Details | ||
|
|
||
| ## Approach | ||
|
|
||
| Update `sanitizeData` so wrapped sanitization failures expose only safe | ||
| diagnostic metadata instead of retaining caller payloads. Keep the public | ||
| `DataSanitizationError` shape intact while replacing raw `originalData` entries | ||
| with input type and wrapped error metadata that callers can log without leaking | ||
| sensitive values. | ||
|
|
||
| ## Pre-implementation | ||
|
|
||
| Create issue branch `fix/279/sanitization_error_details` for GitHub issue #279. | ||
|
|
||
| ## Steps | ||
|
|
||
| 1. Update `src/index.ts` to build safe error details for invalid input and | ||
| wrapped failures. | ||
| 2. Update `test/index-errors.test.ts` with regression coverage for malformed | ||
| sanitized JSON and sensitive payload values. | ||
| 3. Update `README.md` so the error handling example logs safe fields instead of | ||
| raw details. | ||
|
|
||
| ## Relevant Files | ||
|
|
||
| - `docs/plans/003-sanitization-error-details.md` - new plan for issue #279. | ||
| - `src/index.ts` - updated sanitizer error details. | ||
| - `test/index-errors.test.ts` - updated regression coverage for safe error | ||
| details. | ||
| - `README.md` - updated error handling guidance. | ||
|
|
||
| ## Verification | ||
|
|
||
| Run the full test suite, linting, and formatting checks through package scripts. | ||
|
|
||
| ## Decisions | ||
|
|
||
| - Preserve `DataSanitizationError.details` as a structured object so existing | ||
| callers keep a stable error shape. | ||
| - Use safe metadata instead of sanitized payload summaries because parse failures | ||
| happen when the sanitized payload may be malformed, and summaries can still | ||
| reveal application data shape or user content. | ||
| - Include the wrapped error name for debugging while excluding raw input, error | ||
| objects, messages, and stack traces from public details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.