github workflows#66
Merged
Merged
Conversation
Reviewer's GuideExtends the release GitHub Actions workflow to download platform-specific fzf and ripgrep binaries for each build matrix target, embed them alongside the Rust-built codeactor-codebase binary, and ensure they are executable and verified in dist/bin. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The matrix configuration now duplicates full fzf/rg URLs (including versions) for each target; consider extracting shared version variables or base URLs to reduce duplication and make future upgrades less error-prone.
- When extracting rg, you can simplify and make the script more predictable by using
tar -xzf ... --strip-componentsto drop the leading directory instead offind+mv, which currently may behave unexpectedly if multiplergfiles are present.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The matrix configuration now duplicates full fzf/rg URLs (including versions) for each target; consider extracting shared version variables or base URLs to reduce duplication and make future upgrades less error-prone.
- When extracting rg, you can simplify and make the script more predictable by using `tar -xzf ... --strip-components` to drop the leading directory instead of `find` + `mv`, which currently may behave unexpectedly if multiple `rg` files are present.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Build: