fix(models): rebase relocated submodel paths - #9592
Open
wunianze666-netizen wants to merge 2 commits into
Open
wunianze666-netizen wants to merge 2 commits into
wunianze666-netizen wants to merge 2 commits into
Conversation
wunianze666-netizen
requested review from
JPPhoto,
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
September 18, 2026 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmpinstall_*staging directory after the pipeline is moved into the managed models directory.model_index.jsoncomponent names, and the existing failure behavior when neither path exists.The installer probes the downloaded pipeline before
install_path()moves it. Identification records absolute paths for direct child components, while registration updates only the top-level model path and stores managed paths relative to the models directory. Later, the shared resolver therefore returns a deleted staging path, which Transformers interprets as a Hub repository identifier. The resolved loader fallback—not the persisted relativeconfig.path—is the authoritative current root.Related Issues / Discussions
Closes #9580
QA Instructions
The relocation regression fails before the final implementation when it models a managed record with relative
config.path: the resolver returns the deleted staging path instead of the installed component. It passes after the resolver derives the absolute root fromfallback.parent.After the fix:
git diff --checkand the focused sensitive-path scan also pass. The pytest run emits one existingpytest-asyncioconfiguration warning unrelated to this change.Merge Plan
No special merge plan is required; this is a focused loader-path fix with regression coverage.
Checklist
What's Newcopy (if doing a release after this PR) (not applicable)AI-assisted tooling was used to trace the install lifecycle and develop the focused patch and tests; all listed checks were run against the submitted commit.