fix(text-tool): preserve logical size when committing HiDPI text#9111
Open
DustyShoe wants to merge 2 commits intoinvoke-ai:mainfrom
Open
fix(text-tool): preserve logical size when committing HiDPI text#9111DustyShoe wants to merge 2 commits intoinvoke-ai:mainfrom
DustyShoe wants to merge 2 commits intoinvoke-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a Text Tool bug where committed text could become larger than expected on HiDPI displays such as 150% display scaling.
The commit path was creating the raster object from the uploaded image's physical bitmap dimensions instead of the text's logical canvas dimensions. This change keeps the uploaded bitmap intact, but creates the committed canvas image object with logical
widthandheightso the committed layer matches the on-canvas text size.QA Instructions
Merge Plan
Simple merge.
Checklist
What's Newcopy (if doing a release after this PR)