Feat(canvas): Add temporary bbox move with C key hold#9104
Open
DustyShoe wants to merge 3 commits intoinvoke-ai:mainfrom
Open
Feat(canvas): Add temporary bbox move with C key hold#9104DustyShoe wants to merge 3 commits intoinvoke-ai:mainfrom
DustyShoe wants to merge 3 commits intoinvoke-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds bbox hotkey behavior for canvas. A short tap on
Cselects the bbox tool, and holdingCtemporarily activates bbox until the key is released.This PR also moves temporary bbox hotkey handling into the shared canvas tool state so it works correctly with the existing temporary Space and Alt tool overrides. Persistent tool changes now update the base tool consistently, and focused tests were added for tap, hold, and nested temporary hotkey flows.
As a result it touches more files than it was originally expected.
Related Issues / Discussions
N/A
QA Instructions
Cquickly. Verify that bbox becomes the selected tool.C. Verify that bbox is active only whileCis held and that releasingCreturns to the previous tool.C, then hold Space, releaseC, then release Space. Verify that the active tool returns to the original base tool and does not stay on bbox.Merge Plan
No special merge plan.
Checklist
What's Newcopy (if doing a release after this PR)