-
-
Notifications
You must be signed in to change notification settings - Fork 196
feat: new arch support for banner , full screen ads and mobilesdk module on android #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~819 Documentation is deployed and generated using docs.page. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
- Coverage 43.72% 35.57% -8.15%
==========================================
Files 30 36 +6
Lines 549 658 +109
Branches 151 167 +16
==========================================
- Hits 240 234 -6
- Misses 309 424 +115 🚀 New features to boost your workflow:
|
|
Thank you for your contribution! Great to see someone working on new arch support for Android. Would be great if some more experienced Android developers can help test / review this @mikehardy @DoctorJohn @birdofpreyru @wjaykim |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
No way it has already been two months. I keep telling myself "I'll review this next weekend" 🫠 |
Description
This PR migrates key Android components to React Native’s New Architecture (TurboModules/Fabric) and updates documentation to reflect the current migration status.
Related issues
Release Summary
Android migration to New Architecture for core ads modules; documentation updated to reflect current status.
Checklist
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
GoogleMobileAdsBannerViewNativeComponent) and manager (ReactNativeGoogleMobileAdsBannerAdViewManager).Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter