fix(app): reject unsafe deepSet path segments - #9295
Open
russellwheatley wants to merge 2 commits into
Open
Conversation
russellwheatley
changed the title
russellwheatley
changed the title
russellwheatley
force-pushed
the
fix-app-low-deepset-proto-pollution
branch
from
September 4, 2026 12:42
1decfac to
773c012
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9295 +/- ##
============================================
+ Coverage 69.45% 69.79% +0.35%
- Complexity 2122 2130 +8
============================================
Files 443 438 -5
Lines 25537 25468 -69
Branches 4259 4251 -8
============================================
+ Hits 17733 17772 +39
+ Misses 6404 6357 -47
+ Partials 1400 1339 -61
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
russellwheatley
changed the title
russellwheatley
force-pushed
the
fix-app-low-deepset-proto-pollution
branch
from
September 8, 2026 10:23
773c012 to
6cb70d2
Compare
Packages cross-import each other's built dist output (e.g. database imports @react-native-firebase/app/dist/module/common/deeps), which resolves through the workspace symlink to packages/*/dist/**. Jest's default coveragePathIgnorePatterns only excludes node_modules/, so it was instrumenting both that build artifact and the lib/**.ts source it was compiled from. Any shared file with branches got a second, all-zero coverage entry alongside the real one, which is what made codecov/patch misreport fully-tested lines in deepSet's new guard as partial/miss.
russellwheatley
marked this pull request as ready for review
September 8, 2026 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejects
__proto__,prototype, andconstructorpath segments indeepSetbefore traversal, closing a low-severity prototype-pollution primitive (CWE-1321).deepSet({}, 'constructor.prototype.polluted', true, false)previously walked the inheritedconstructor->prototypechain and wrote ontoObject.prototype, so any unrelated object created afterward inheritedpolluted.packages/app/lib/common/deeps.ts__proto__andconstructor.prototypeattack formsReported privately through the OSS security inbox.
deepSetis currently only reachable internally viaMutatableParams, no remotely-controlled call path was identified.