Skip to content

fix(auth): remove sensitive authentication logs - #9292

Open
russellwheatley wants to merge 1 commit into
mainfrom
fix/auth-medium-remove-sensitive-authentication-logs
Open

fix(auth): remove sensitive authentication logs#9292
russellwheatley wants to merge 1 commit into
mainfrom
fix/auth-medium-remove-sensitive-authentication-logs

Conversation

@russellwheatley

Copy link
Copy Markdown
Member

Native Android and iOS auth code was logging authentication secrets and personal data to debug logs.

  • Android: dropped the full addAuthStateListener event body log, trimmed the phone number out of the verifyPhoneNumber log
  • iOS: removed DLog calls exposing verificationID, MFA phoneNumber/sessionKey, the sign-in credential, TOTP sessionKey/session/secretKey/cached secret, the QR provisioning URL, and the enrollment secret/cached secret

No behavior change, logging only. Validated with prepare, TS compile (lib + consumer), yarn lint, all 105 Jest suites (1522 tests, 31 snapshots), yarn format:js, and yarn compare:types.

Reported by @OskarEichler.

@russellwheatley russellwheatley changed the title fix(auth): [MEDIUM] remove sensitive authentication logs fix(auth): remove sensitive authentication logs Sep 4, 2026
@russellwheatley
russellwheatley force-pushed the fix/auth-medium-remove-sensitive-authentication-logs branch from b01c08d to b1a63eb Compare September 4, 2026 10:44
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.44%. Comparing base (afaba0b) to head (b1a63eb).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9292      +/-   ##
============================================
- Coverage     69.45%   69.44%   -0.00%     
  Complexity     2122     2122              
============================================
  Files           443      443              
  Lines         25537    25536       -1     
  Branches       4259     4259              
============================================
- Hits          17733    17732       -1     
  Misses         6404     6404              
  Partials       1400     1400              
Flag Coverage Δ
android-native 65.75% <100.00%> (-<0.01%) ⬇️
e2e-ts-android 54.14% <ø> (ø)
e2e-ts-ios 53.61% <ø> (ø)
e2e-ts-macos 49.88% <ø> (ø)
ios-ruby 100.00% <ø> (ø)
jest 47.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@russellwheatley
russellwheatley marked this pull request as ready for review September 8, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants