fix(auth): remove sensitive authentication logs - #9292
Open
russellwheatley wants to merge 1 commit into
Open
Conversation
russellwheatley
force-pushed
the
fix/auth-medium-remove-sensitive-authentication-logs
branch
from
September 4, 2026 10:44
b01c08d to
b1a63eb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9292 +/- ##
============================================
- Coverage 69.45% 69.44% -0.00%
Complexity 2122 2122
============================================
Files 443 443
Lines 25537 25536 -1
Branches 4259 4259
============================================
- Hits 17733 17732 -1
Misses 6404 6404
Partials 1400 1400
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
russellwheatley
marked this pull request as ready for review
September 8, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Android and iOS auth code was logging authentication secrets and personal data to debug logs.
addAuthStateListenerevent body log, trimmed the phone number out of theverifyPhoneNumberlogDLogcalls exposingverificationID, MFAphoneNumber/sessionKey, the sign-incredential, TOTPsessionKey/session/secretKey/cached secret, the QR provisioning URL, and the enrollment secret/cached secretNo behavior change, logging only. Validated with prepare, TS compile (lib + consumer),
yarn lint, all 105 Jest suites (1522 tests, 31 snapshots),yarn format:js, andyarn compare:types.Reported by @OskarEichler.