Skip to content

Conversation

@AlejandroGomezE
Copy link
Contributor

Description
This PR aims to provide more clarity to the MFA phone sign in flow.

Related issues:
The current documentation shows an outdated function call for the mfa phone vericationId get funcion.

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • [] Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Description
This PR aims to provide more clarity to the MFA phone sign in flow. 

Related issues:
The current documentation shows an outdated function call for the mfa phone vericationId get funcion.
@vercel
Copy link

vercel bot commented Oct 10, 2025

@AlejandroGomezE is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2025

CLA assistant check
All committers have signed the CLA.

@AlejandroGomezE AlejandroGomezE changed the title Update multi-factor-auth.md fix: multi-factor-auth docs are incorrect Oct 20, 2025
@github-actions
Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Nov 17, 2025
@mikehardy mikehardy removed the Stale label Nov 19, 2025
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this sat! I think you are correct and this appears to be a good change, thank you

@mikehardy
Copy link
Collaborator

Only doing a close/open cycle to revive the CI jobs

@mikehardy mikehardy closed this Nov 19, 2025
@mikehardy mikehardy reopened this Nov 19, 2025
@mikehardy mikehardy changed the title fix: multi-factor-auth docs are incorrect docs(auth): align phone SMS MFA flow docs with current APIs Nov 19, 2025
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Nov 19, 2025
@mikehardy mikehardy merged commit c9ceb45 into invertase:main Nov 19, 2025
5 of 9 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants