fix: firebase_core folder order by parsing the version #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
changed the title
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
force-pushed
the
features/fred/fix-version-order
branch
from
23e2703 to
fb08e9c
Compare
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Contributor
Author
|
@russellwheatley Could you review this please? |
github-actions
bot
added
the
Needs Attention
frederikstonge
had a problem deploying
to
CI Environment
GitHub Actions
Error
frederikstonge
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
frederikstonge
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
frederikstonge
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
russellwheatley
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue where folder ordering by name would think firebase_core-3.3.0 was higher than firebase_core-3.14.0. I used pub_semver to parse the version to make sure we get the latest version. It might look redundant, but I decided to filter out other package folders to make sure we don't parse the version of all the pub cache folders.
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore