docs: document the append spot-check's second blind spot (#66) - #68
Merged
Conversation
journeys/testgraph.json's spot_checks.append passes today, but not for the reason it claims to: the 5+ caller edges it counts are all fabricated by a codegraph resolver bug, not the two real callers (record.py:add_outcome, hook.py:log_invocation). Records the root cause, the measured edge counts, and that a fix exists but isn't deployed to the codegraph build in use, so the spot-check should be treated as unreliable until a release picks it up.
Named one example plus "five more" (6 total), but the actual non-identifier- receiver .append() call sites this paragraph describes number 7 across export.py/db.py/propose.py/select.py — matching the paragraph's own "7 fabricated edges, measured" figure. Caught by code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
journeys/testgraph.json'sspot_checks.appendpasses today, but not for the reason it claims to check: the caller edges it counts onledger.py:appendare fabricated by a codegraph resolver bug, not the two real callers (record.py:add_outcome,hook.py:log_invocation).codegraphbuild this machine runs.Test plan
python3 -m pytest tests/test_registries.py -q— 6 passedpython3 -m pytest tests/ -q— 251 passedpython3 -c "import json; json.load(open('journeys/testgraph.json'))")