Skip to content

Update Open InterSystems Document... command to show a flat list of documents#1804

Open
isc-bsaviano wants to merge 2 commits into
intersystems-community:masterfrom
isc-bsaviano:flat-open-document
Open

Update Open InterSystems Document... command to show a flat list of documents#1804
isc-bsaviano wants to merge 2 commits into
intersystems-community:masterfrom
isc-bsaviano:flat-open-document

Conversation

@isc-bsaviano

Copy link
Copy Markdown
Contributor

This PR implements an enhancement requested internally. A flat list of files is preferable because it helps users open their document with fewer keystrokes due to better filtering.

Current behavior:

before.mov

New behavior:

after.mov

@gjsjohnmurray

Copy link
Copy Markdown
Contributor

Did you consider adding a toggle button (View as List / View as Tree) so we don't risk upsetting folk who like how it currently behaves?

@isc-bsaviano

Copy link
Copy Markdown
Contributor Author

I didn't. I'm not sure why anyone would prefer the existing behavior. I think I implemented it that way originally expecting that users would want to click through the items to select the document. Feedback from users showed that they use the input box more often. The only potential downside to this change is that loading the flat list of documents might take a lot longer than the hierarchical list. However, the QuickPick won't be locked while the list is loading so the user could type the full name or type a filter string and wait for the list to load and be filtered.

isc-klu
isc-klu previously approved these changes Jul 8, 2026
@gjsjohnmurray

Copy link
Copy Markdown
Contributor

@isc-bsaviano in the end it's your decision, but dropping the hierarchical approach may give rise to complaints, particularly from sites with a very large overall number of classes but a package structure that keeps lists of classes relatively short.

@isc-bsaviano

Copy link
Copy Markdown
Contributor Author

My most recent commit only shows web app files for server-side web app folders. That could significantly improve performance since IRIS wouldn't need to read the file system. While that doesn't address the UX gap for people who preferred the old way, it should ease it a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants