WEBDEV-8972: Run CI on PRs based on any branch - #88
Closed
jbuckner wants to merge 1 commit into
Closed
Conversation
The pull_request branches filter matches the PR's base branch, so a PR stacked on another PR's branch ran no tests until GitHub retargeted it to main. A reviewer looking at the middle of a stack saw a green PR that was never tested. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CUM1e29MLyK3kBDiZYgERx
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 81.12% 81.44% +0.32%
==========================================
Files 27 27
Lines 927 927
Branches 227 227
==========================================
+ Hits 752 755 +3
+ Misses 113 110 -3
Partials 62 62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
latonv
approved these changes
Aug 27, 2026
Collaborator
Author
|
Superseded by #90, which is already merged to The two changes are the same fix — drop the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull_request: branches: [main]filters on the PR's base branch, so any PR stacked on another PR's branch ran no tests at all. It only got deploy-preview, which has no filter. The tests did eventually run once GitHub retargeted the PR to main, but that's after review, so a reviewer in the middle of a stack saw a green PR that was never tested. Live example: PR #82 has no build job.Dropping the filter from
pull_requestfixes it. Kept the push filter so post-merge runs stay on main only.One correction to the ticket: CodeQL isn't affected. It's not a workflow in this repo, it's GitHub's managed Code Quality (
dynamic/github-code-quality/codeql), which has no branch filter and does run on stacked PRs (see PR #82, where it passed).https://webarchive.jira.com/browse/WEBDEV-8972
🤖 Generated with Claude Code
https://claude.ai/code/session_01CUM1e29MLyK3kBDiZYgERx