Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds explicit serial transport framing/buffering controls to the smpmgr CLI while keeping --mtu working for backwards compatibility (now deprecated for serial).
Changes:
- Introduces
--line-lengthand--line-buffersCLI options and threads them into the runtimeOptions. - Updates serial transport initialization to derive
max_smp_encoded_frame_size = line_length * line_buffers, with legacy--mtumapped toline_length=mtu, line_buffers=1and guarded against mixed usage. - Adds an LLM-generated research note on SMP serial parameter naming/defaults and updates VS Code workspace settings for Poetry env/package management.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
smpmgr/main.py |
Adds CLI flags for serial line length/buffer count; updates --mtu help text and passes new values into Options. |
smpmgr/common.py |
Adds defaults and implements serial transport argument selection/validation (including --mtu deprecation behavior). |
docs/llm/smp-serial-naming-research.md |
Adds a research document supporting naming/default decisions for SMP serial parameters. |
.vscode/settings.json |
Sets Poetry as the default env/package manager for VS Code’s Python environment tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cef4e01 to
18ca293
Compare
18ca293 to
d590a94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long overdue feature to allow setting the "line length" and "line buffers". "mtu" is deprecated, but will continue being interpreted as it always has: line_length = mtu, line_buffers = 1.
Many investigations and conversations have confirmed that the line length never should have been configurable in the first place. Including in Zephyr, MCUboot etc. But, we need to continue supporting non-standard line lengths since there are many units in the field that changed the line length as a speed up.
Also committed is an LLM generated report regarding naming and defaults.