Repository navigation
fix: make the bundled pace pause zero minutes - #885
Merged
Merged
Conversation
A run that set no pace stopped every stage, landings included, for 300 minutes after each 120-minute window. The product thinker ruled that no pause is needed and that the default must be zero, so the bundled pace is now 120/0: a run with no pace configured opens window after window without pausing, and a repository or machine that wants a pause sets pace.pause_minutes. The window, the sub-agent ceiling and the fix rounds are unchanged. The ruling is in the decision log. Resolves: iss-2610100546338578 Assisted-by: Claude:claude-opus-5-5
Pacing's rate-limit checkpoint waits the run's pause, which is now zero by default, so a rate-limited run would retry at once. The product thinker ruled that a rate limit waits on its own, as later work. Refs: iss-2610100602595553, iss-2610100546338578 Assisted-by: Claude:claude-opus-5-5
Collaborator
Author
The rate-limit tests measured the window's early end against the bundled pause, which is now zero minutes: a zero pause lets the next step start at once, so "a step inside the pause refuses" had no pause to refuse inside. They now start their runs with a 300-minute pause. Assisted-by: Claude:claude-opus-5-5
The reviewers of PR #886 passed it with notes below their bar. Five are captured: three small defects in the rate-limit and budget code, the budget check that no shipped runner can reach, and the runners that cannot recognise a rate limit. The three defects are deferred in DECISIONS.md with the reason: none is reachable without a second fault, and the drain's next steps rework the same code. Refs: itd-2609201925079472 Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run that set no pace stopped every stage, landings included, for 300 minutes after each 120-minute window. On the product thinker's ruling of 2026-10-10, the bundled pace is now 120/0: a run with no pace configured opens window after window without pausing, and a repository or machine that wants a pause sets
pace.pause_minutes. The window, the sub-agent ceiling and the fix rounds are unchanged.BundledPauseMinutesis 0 (internal/core/implement/loop/pace.go); the two tests of the bundled pace now expect 120/0, and they failed against 300 before the change.The build help,
commands/build.md, the generated CLI reference and the build brief chapter name the new default.The ruling is appended to
.abcd/work/DECISIONS.md; it supersedes the pause in decision 5 of itd-2609201925079472, whose record is left as written.Resolves iss-2610100546338578.
Captures iss-2610100602595553: pacing's rate-limit checkpoint waits the run's pause, so with a zero pause it would retry at once; a rate limit gets its own wait as later work.
Merges main after pacing (build(itd-2609201925079472): the whole spec, step 1 of spc-2609301921521360 #886) landed. Two of build(itd-2609201925079472): the whole spec, step 1 of spc-2609301921521360 #886's rate-limit tests measured the window's early end against the bundled pause; with a zero pause the next step starts at once, so they failed. They now start their runs on a 300-minute pause of their own and pass.
Captures five notes from build(itd-2609201925079472): the whole spec, step 1 of spc-2609301921521360 #886's reviewers (iss-2610100913086397, iss-2610100913088696, iss-2610100913096412, iss-2610100913096346, iss-2610100913095172). The first three are small defects in the rate-limit and budget code;
.abcd/work/DECISIONS.mddefers them and gives the reason.Resolves: iss-2610100546338578
Refs: iss-2610100602595553
Refs: iss-2610100913086397
Refs: iss-2610100913088696
Refs: iss-2610100913096412
Refs: iss-2610100913096346
Refs: iss-2610100913095172
Assisted-by: Claude:claude-opus-5-5