Repository navigation
docs: bring post-cut docs and flag help current for v0.13.3 - #872
Merged
Merged
Conversation
The v0.13.3 cut's docs review deferred five findings. launch.md and the --allow-dirty flag help now name the findings gate's refusal of an uncommitted issue record under open/ (and the help names the cut's uncommitted-records refusal), neither of which the flag waives. prepare-this-repo sets a local core.hooksPath only when the clone reads unarmed and leaves a foreign hooks path alone, and names .abcd/record-lint.json in full. The implement step --discard help now gives the order the code runs: worktree and branch first, then the pull request. The CLI reference is regenerated. Refs: iss-2610081312364884 Assisted-by: Claude:claude-opus-5-5
Moves the issue to resolved/, pointing at the commit that brought launch.md, prepare-this-repo.md and the --allow-dirty and --discard flag help current with the code. Resolves: iss-2610081312364884 Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The post-cut documentation follow-up for v0.13.3. The cut's docs-currency review deferred three findings (dc-1 to dc-3), and its crosscheck left two side notes (a14, a30). This change fixes all five so the docs match the code:
commands/launch.md. The findings gate also refuses when any issue record under.abcd/work/issues/open/differs from HEAD (uncommittedOpenRecordsininternal/core/changelog/findings.go). That refusal is surfaced underunfixed-finding. The page now describes it in The findings gate, mentions it in the exit-1 list, and names it in the--allow-dirtyparagraph as something the flag never waives.commands/prepare-this-repo.mdstep 5.git config core.hooksPath .githooksis now conditional. It runs only when the detection pass reportsbanlist.hooks_pathasunarmed. When it reportsforeign, the step leaves the global or system dispatcher alone, matchingcommands/ahoy.mdand the binary's own hint. The install result does not carryhooks_path, so the step reads it fromahoy --json.--allow-dirtyhelp (internal/surface/cli/ship.go). The list of refusals the flag never waives now includes the cut'suncommitted-recordsrefusal and the findings gate's refusal of an uncommitted open/ record.prepare-this-repo.mdnow gives the full path.abcd/record-lint.jsoninstead of a barerecord-lint.json.implement step --discardhelp now gives the order the code runs (loop.Discardinhold.go) and that the long help already states: it removes the worktree and branch, then closes the pull request.docs/reference/cli/commands.mdis regenerated withgo generate ./internal/surface/cli. The surface baseline is unchanged.Why
These are user-facing claims that disagreed with the shipped binary. The ledger records the set as one issue, which this change captures and resolves. It is two commits: the fix, then the move to
resolved/that points at it.Resolves: iss-2610081312364884
Assisted-by: Claude:claude-opus-5-5