Repository navigation
CborPretty: fix crash in unusal combination of flags - #344
Merged
thiagomacieira merged 1 commit intoOct 23, 2026
Merged
thiagomacieira merged 1 commit into
thiagomacieira merged 1 commit into
Conversation
In `resolve_indicator()`, if we were resolving indicators for overlong
numbers but not for indeterminate length, we could end up calling
`extract_number_checked()` on an indeterminate length, which would then
correctly return CborErrorIllegalNumber (because it's not a
number). That would cause `resolve_indicator()` to incorrectly return
NULL on something that isn't a real error.
As a result, at least one caller crashed because it dereferenced the result:
```c
/* recursive type */
CborValue recursed;
const char *indicator = get_indicator(it, flags);
const char *space = *indicator ? " " : indicator;
```
This wasn't caught before by unit-testing because tst_parser did not
test this combination of flags (it was testing the parser, not the
pretty-printer). Therefore, I've added an extensive suite for testing
the pretty-printer.
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
deleted the
CborPretty_fix_crash_in_unusal_combination_of_flags
branch
October 23, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
resolve_indicator(), if we were resolving indicators for overlong numbers but not for indeterminate length, we could end up callingextract_number_checked()on an indeterminate length, which would then correctly return CborErrorIllegalNumber (because it's not a number). That would causeresolve_indicator()to incorrectly return NULL on something that isn't a real error.As a result, at least one caller crashed because it dereferenced the result:
This wasn't caught before by unit-testing because tst_parser did not test this combination of flags (it was testing the parser, not the pretty-printer). Therefore, I've added an extensive suite for testing the pretty-printer.