Repository navigation
cbortojson: adapt to work with picolibc's variant of funopen - #341
Merged
thiagomacieira merged 1 commit intoOct 19, 2026
Conversation
Instead of matching the API first introduced by 4.4BSD, picolibc decided
to be different.
```
tinycbor/src/open_memstream.c:103:29: error: passing argument 3 of 'funopen' from incompatible pointer type [-Wincompatible-pointer-types]
103 | return funopen(b, NULL, write_to_buffer, NULL, close_buffer);
| ^~~~~~~~~~~~~~~
| |
| RetType (*)(void *, const char *, LenType) {aka int (*)(void *, const char *, int)}
In file included from tinycbor/src/open_memstream.c:31:
picolibc/include/stdio.h:429:28: note: expected '_ssize_t (*)(void *, const void *, size_t)' {aka 'int (*)(void *, const void *, unsigned int)'} but argument is of type 'RetType (*)(void *, const char *, LenType)' {aka 'int (*)(void *, const char *, int)'}
429 | _ssize_t (*writefn)(void *cookie, const void *buf, size_t n),
|
```
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
deleted the
cbortojson_adapt_to_work_with_picolibc_s_variant_of_funopen_
branch
October 19, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of matching the API first introduced by 4.4BSD, picolibc decided to be different.