[SYCL] Fix FileCheck patterns for new dead_on_return attribute ordering - #22916
Open
wenju-he wants to merge 1 commit into
Open
[SYCL] Fix FileCheck patterns for new dead_on_return attribute ordering#22916wenju-he wants to merge 1 commit into
wenju-he wants to merge 1 commit into
Conversation
Merge commit 2044c11 pulled in upstream commit 2915160 ("[Clang][CodeGen] Emit dereferenceable and nofree for indirect arguments"), which now emits a dereferenceable(N) attribute alongside dead_on_return for indirect-but-not-byval parameters. This broke exact-match CHECK lines in these tests. Relax the patterns to tolerate the additional attributes. CMPLRLLVM-77558 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
elizabethandrews
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge commit 2044c11 pulled in upstream commit 2915160 ("[Clang][CodeGen] Emit dereferenceable and nofree for indirect arguments"), which now emits a dereferenceable(N) attribute alongside dead_on_return for indirect-but-not-byval parameters. This broke exact-match CHECK lines in these tests. Relax the patterns to tolerate the additional attributes.
CMPLRLLVM-77558