[SYCL][E2E] Fix invalid reqd_work_group_size in large-reqd-work-group-size.cpp#22459
Open
wenju-he wants to merge 1 commit into
Open
[SYCL][E2E] Fix invalid reqd_work_group_size in large-reqd-work-group-size.cpp#22459wenju-he wants to merge 1 commit into
wenju-he wants to merge 1 commit into
Conversation
…-size.cpp The test fails after 6794e31 which adds reqd_work_group_size product overflow check to IR verifier. This PR fixes the test. SYCL 2020 spec (Secion 4.9.1.1, Table 79) defines range::size() as product of its dimensions and return type is size_t. The product of reqd_work_group_size should fit within range::size() return type. CMPLRLLVM-76460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test fails after 6794e31 which adds reqd_work_group_size product overflow check to IR verifier. This PR fixes the test.
SYCL 2020 spec (Secion 4.9.1.1, Table 79) defines range::size() as product of its dimensions and return type is size_t. The product of reqd_work_group_size should fit within range::size() return type.
CMPLRLLVM-76460