[SYCL] Add removal guard for info::device::atomic64 use-cases#22456
Open
Robertkq wants to merge 1 commit into
Open
[SYCL] Add removal guard for info::device::atomic64 use-cases#22456Robertkq wants to merge 1 commit into
info::device::atomic64 use-cases#22456Robertkq wants to merge 1 commit into
Conversation
Contributor
Author
|
@KornevNikita can you please review the PR when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #14920
This PR guards all
info::device::atomic64related code in include guards for breaking changes.I have manually tested a sample app that was querying for this info, providing the
-fpreview-breaking-changescompile flag to it is now failing with the follow error:Which I think is the expected result for the next major release.