[CI] Add Pytorch Linux testing to Nightly#22441
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
FYI in case you are interseted @dvrogozh |
dvrogozh
left a comment
dvrogozh
left a comment
There was a problem hiding this comment.
Just tips on how I would do. Consider as nit.
| name: ${{ env.PYTORCH_WHEEL_ARTIFACT }} | ||
| path: dist | ||
|
|
||
| - name: Clone PyTorch Test Sources |
There was a problem hiding this comment.
I would also replace it with actions/checkout. It's also tunable for depth though 1 is a default I think.
| env: | ||
| PYTORCH_REF: ${{ inputs.pytorch_ref }} | ||
| run: | | ||
| git clone https://github.com/pytorch/pytorch.git "$PYTORCH_SRC_DIR" |
There was a problem hiding this comment.
Why not to use actions/checkout? I also not sure why do you need ${{ env.PYTORCH_SRC_DIR }} instead of hardcoding somethin relative to current directory.
There was a problem hiding this comment.
I am not sure why do you need these 2 here. By default everything will be executed in the pwd=$GITHUB_WORKSPACE. So you can hardcode relatives paths everywhere when needed such as ./pytorch and ./llvm/devops. The only inconvenience will be that you will have multiple cloned repo in the root, i.e. ./llvm/devops instead of ./devops:
- name: Checkout devops scripts
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
path: llvm
sparse-checkout: |
devops/
persist-credentials: false
- name: Checkout pytorch
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: pytorch/pytorch
ref: ${{ inputs.pytorch_ref }}
submodules: recursive
path: pytorch
4 participants
Add a workflow to build and test Pytorch on Linux and run it in the nightly.
Example nightly run: https://github.com/intel/llvm/actions/runs/28252539540/job/83724245754