[SYCL] Preserve restrict on free function kernel pointer args#21989
Open
koparasy wants to merge 2 commits into
Open
[SYCL] Preserve restrict on free function kernel pointer args#21989koparasy wants to merge 2 commits into
koparasy wants to merge 2 commits into
Conversation
Preserve top-level pointer qualifiers when rewriting SYCL free function kernel pointer parameters into global address space, so restrict lowers to LLVM noalias on generated kernel arguments. Add device-code coverage for restrict-qualified free function kernel and helper parameters.
bader
approved these changes
May 12, 2026
Fznamznon
reviewed
May 12, 2026
| @@ -0,0 +1,30 @@ | |||
| // RUN: %clangxx -fsycl-device-only -S -Xclang -emit-llvm -Xclang -disable-llvm-passes %s -o - | FileCheck %s --check-prefix CHECK-IR | |||
Contributor
There was a problem hiding this comment.
I don't see why this test is added to sycl directory. The tests in sycl/test/check_device_code exist to make sure that SYCL headers correctly use front-end provided features to produce expected IR. I don't see anything specific for our SYCL headers in this test therefore it is easier to add a test to clang/test/CodeGenSYCL directory.
Contributor
Author
There was a problem hiding this comment.
Thanks! That sounds about right. Moved the test under the requested directory.
Fznamznon
reviewed
May 12, 2026
Comment on lines
+3
to
+4
| #include <sycl/ext/oneapi/experimental/free_function_traits.hpp> | ||
| #include <sycl/sycl.hpp> |
Contributor
There was a problem hiding this comment.
Could you please also align this test with other tests in CodeGenSYCL? General changes that should be done are:
- Don't use clang driver in front-end tests, i.e. clang_cc1 substitute instead of clangxx
- Use mock SYCL headers available in CodeGenSYCL/Inputs to avoid dependency on our SYCL headers
Other tests for free functions in CodeGenSYCL are good examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve top-level pointer qualifiers when rewriting SYCL free function kernel pointer parameters into global address space, so restrict lowers to LLVM noalias on generated kernel arguments. Add device-code coverage for restrict-qualified free function kernel and helper parameters.
I changed
ModifyAddressSpacebecause that is where SYCL reconstructs rewritten pointer types. It was preserving pointee qualifiers but dropping top-level pointer qualifiers such as__restrict__, which caused the generated kernel parameters to lose LLVMnoalias.