[SYCL][NewOffloadModel][E2E] adjust separate_compile.cpp test to SeparateCompile/test.cpp#21980
Open
maksimsab wants to merge 2 commits into
Open
[SYCL][NewOffloadModel][E2E] adjust separate_compile.cpp test to SeparateCompile/test.cpp#21980maksimsab wants to merge 2 commits into
maksimsab wants to merge 2 commits into
Conversation
…rateCompile/test.cpp These tests are related. However, the one for NewOffloadModel skipped `-Wno-unused-command-line-argument` flag leading to compilation error in windows environment.
retrigger testing
hchilama
approved these changes
May 12, 2026
Contributor
hchilama
left a comment
hchilama
left a comment
There was a problem hiding this comment.
Looks ok to me to silence the expected-but-noisy warnings to fix Windows test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These 2 tests are related. However, the one for NewOffloadModel lost
-Wno-unused-command-line-argumentflag leading to compilation error in Windows environment.fixes: CMPLRLLVM-74117