[TEST][E2E][CUDA] Fix WorkGroupScratchMemory/missing_launch_property.cpp failure#21965
Open
kweronsx wants to merge 1 commit into
Open
[TEST][E2E][CUDA] Fix WorkGroupScratchMemory/missing_launch_property.cpp failure#21965kweronsx wants to merge 1 commit into
kweronsx wants to merge 1 commit into
Conversation
slawekptak
approved these changes
May 11, 2026
Contributor
slawekptak
left a comment
slawekptak
left a comment
There was a problem hiding this comment.
SYCL test changes LGTM.
Contributor
|
Please, add more descriptive commit message. The current is not sufficient. |
bratpiorka
reviewed
May 12, 2026
kweronsx
force-pushed
the
fix-workgroup-scratch-memory
branch
from
509ee4e to
7f80e6f
Compare
bratpiorka
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the WorkGroupScratchMemory/missing_launch_property.cpp E2E test failure on CUDA (tracked in #21924).
Extends two conditional checks to also handle PTX_Kernel calling convention alongside SPIR_KERNEL. This ensures that work-group scratch memory attributes (WORK_GROUP_SCRATCH_ATTR) are correctly detected and applied for CUDA kernels, not just SPIR kernels.
Adds a LIT test verifying that ptx_kernel (CUDA) functions calling __sycl_dynamicLocalMemoryPlaceholder are correctly lowered by sycllowerwglocalmemory: the placeholder call is replaced by a reference to a real shared-memory global, and the "sycl-work-group-scratch" attribute is stamped on the kernel so the host-side launcher knows to wire up dynamic shared memory at launch.