[UR][CUDA] Fix IL_VERSION query to include null terminator#21600
Open
[UR][CUDA] Fix IL_VERSION query to include null terminator#21600
Conversation
The UR_DEVICE_INFO_IL_VERSION query was returning PTX ISA version string using ILVersion.data() and ILVersion.size(), which did not include the null terminator. This caused test failures because the conformance test expects the returned string to be null-terminated. Changed to use ILVersion.c_str() to return a properly null-terminated string, consistent with other string properties in the same file. This fix enables the SuccessILVersion conformance test for CUDA adapter.
bratpiorka
approved these changes
Mar 24, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UR_DEVICE_INFO_IL_VERSION query was returning PTX ISA version string using ILVersion.data() and ILVersion.size(), which did not include the null terminator. This caused test failures because the conformance test expects the returned string to be null-terminated.
Changed to use ILVersion.c_str() to return a properly null-terminated string, consistent with other string properties in the same file.
This fix enables the SuccessILVersion conformance test for CUDA adapter.