[UR][TEST] Clarify known-failure rationale for kernel subgroup query test#21566
Draft
[UR][TEST] Clarify known-failure rationale for kernel subgroup query test#21566
Conversation
kweronsx
force-pushed
the
test/check-kernel-test-failing-adapters
branch
2 times, most recently
from
dda44b4 to
8f7dafc
Compare
kweronsx
changed the title
Contributor
Author
|
After reviewing the adapter implementations, it appears that many backend APIs do not provide the functionality needed to query the required number of work subgroups, instead returning a hardcoded value. Those that do support this query often fail because the hardware is incompatible with the kernel program built during the test, causing the test to fail before it can verify the retrieved data against the expected value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify UUR_KNOWN_FAILURE_ON macro invocation to see if the two adapters fail, since they do seem to have a non-trivial implementation, unlike the CUDA, HIP, NATIVE_CPU, and OFFLOAD adapters.