Repository navigation
[CI] Pin smoke.yml actions to commit SHAs and name the build job - #435
Merged
Merged
Conversation
zizmor 1.30.1 reports unpinned-uses (high) for actions/checkout@v7 and the
six actions/cache/{restore,save}@v6 steps, plus anonymous-definition (info)
for the build job. Pin each action to the commit its major tag points to
today, keeping the version in a trailing comment so Dependabot can keep
bumping it, and give the job a name. zizmor --persona=pedantic now reports
no findings.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AndreyPavlenko
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all zizmor findings in
.github/workflows/smoke.yml.zizmor 1.30.1 reports 8 findings on the current workflow:
unpinned-usesactions/checkout@v7(line 29)unpinned-usesactions/cache/restore@v6(lines 73, 79, 114)unpinned-usesactions/cache/save@v6(lines 102, 108, 128)anonymous-definitionbuild(line 17)A tag such as
v7can be moved to different code at any time, while a commit SHA cannot.Changes
Pin every action to the commit its major tag points to today:
actions/checkout@v7→3d3c42e5aac5ba805825da76410c181273ba90b1(v7.0.1)actions/cache/{restore,save}@v6→55cc8345863c7cc4c66a329aec7e433d2d1c52a9(v6.1.0)Each pin keeps the version in a trailing comment, so the existing Dependabot
github-actionsconfig keeps proposing updates.Name the job
Build and smoke test.The workflow runs exactly the same action code as before. The parsed workflow is identical to the original apart from the pinned refs and the job name.
Testing
zizmor --persona=pedantic .github/workflows/smoke.yml(offline and with a GitHub token): no findings.🤖 Generated with Claude Code