🎨 Improvements for bitset - #418
Merged
Merged
Conversation
Problem: - `bitset` construction from a `string_view` uses `substr` which may throw, and it's a really niche use case anyway. Solution: - Remove it.
Problem: - There's no need for `for_each` and `transform` to be `friend`s of `bitset` since the member functions are public. Solution: - Remove the `friend` declarations.
Problem: - It's awkward that `bitset<16>` and `bitset<16u>` are different types. Solution: - Fix the argument of `bitset` to a `std::size_t` in the cases it's not an enum.
elbeno
requested review from
SANTOSHKUMARLAXMINARAYANRAI,
lukevalenty,
mjcaisse-intel and
siauthun
September 9, 2026 22:50
SANTOSHKUMARLAXMINARAYANRAI
approved these changes
Sep 9, 2026
elbeno
enabled auto-merge
September 9, 2026 23:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
bitsetconstruction from astring_viewusessubstrwhich may throw, and it's a really niche use case anyway.for_eachandtransformto befriends ofbitsetsince the member functions are public.bitset<16>andbitset<16u>are different types.Solution:
bitset'sstring_viewconstructor.frienddeclarations.bitsetto astd::size_tin the cases it's not an enum.