Skip to content

Conversation

@kishaningithub
Copy link

@kishaningithub kishaningithub commented Jul 24, 2025

Resolves #2709


Before the change?

  • Preemptive rate limiting is by default enabled by go-github which makes the concurrent requests to fail

After the change?

  • Premptive rate limiting by go-github library is eliminated thereby giving the complete rate limiting control to this provider.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell
Copy link
Collaborator

@kishaningithub upgrading the SDK version is going to be complicated as there are going to be a significant number of related changes required.

@kishaningithub
Copy link
Author

I understand, would be great if we can simplify this and get it done

Let me know your ideas

@stevehipwell
Copy link
Collaborator

@kishaningithub I've added a comment to your issue, we should probably have any discussions there.

@nickfloyd nickfloyd moved this from Backlog to BLOCKED in Terraform Provider Nov 20, 2025
@kishaningithub
Copy link
Author

Waiting on this PR to be merged #2898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: BLOCKED

Development

Successfully merging this pull request may close these issues.

[FEAT]: Bypass preemptive rate limit check by go-github

2 participants