Open
Conversation
Contributor
There was a problem hiding this comment.
The changes are aesthetic; it seems that the code has not been substantially modified.
These lines should make a difference but they are equal to the previous ones.
New:
// Apply buffer (positive = external, negative = internal)
IShape newShape = workingShape.buffer(bdistance);
Old:
IShape newShape = oshape.buffer(bdistance);
Try entering negative values into the actual code. If this doesn't work, we can check which changes are necessary.
|
It does work. Many thanks for your prompt attention to this! I'll make a note in quick tips that negative values for an inner buffer are also possible. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This code, which works for the feature requested by Ken, needs to be double checked as it is fully AI generated.
When given a negative radius now creates a new smaller object compared to the original one, considering the radius absolute value.
This allows to create a raster buffer in a second step:
e.g. try in "Bilbao"