feat(ui-codemods): update tokens and move theme.componentOverrides to…#2637
Conversation
|
Visual regression report
Baselines come from the |
| @@ -0,0 +1,21 @@ | |||
| // @ts-nocheck | |||
There was a problem hiding this comment.
From the codemod's point of view Checkbox is tricky because the same old token maps to different new tokens depending on the variant (simple vs toggle), so it can't do a straight one-to-one rename — and when the variant can't be determined statically it has to leave those tokens alone and warn. On top of that it has separate facade keys (Checkbox/CheckboxFacade/ToggleFacade) that each keep their own tokens, so they can't be merged.
| {name:"colorLicorice",note:"color system reworked to accent1-6; use the <color>BackgroundColor/<color>TextColor tokens"}, | ||
| {name:"colorAsh",note:"color system reworked to accent1-6; use the <color>BackgroundColor/<color>TextColor tokens"}, | ||
| {name:"aiFontColor",note:"the AI variant text now uses textOnColor"}, | ||
| {name:"fontFamily",note:""} |
There was a problem hiding this comment.
This variable still exists in 11.7
There was a problem hiding this comment.
No, it is in Avatar/v1/styles.ts but not in Avatar/v2/styles.ts
a101407 to
e675030
Compare
… themeOverride.components INSTUI-4840
e675030 to
e4d7873
Compare
matyasf
left a comment
There was a problem hiding this comment.
nice work! The test caught a bug too (INSTUI-5103)

… themeOverride.components
INSTUI-4840
1. Renames and removes theme tokens.
2. Updates how overrides are set on InstUISettingsProvider.
3. Revises the token list in the upgrade guide.
4. Ships with a full test suite.
TEST PLAN:
1. Confirm the tests actually catch mistakes
backgroundColor→bogusColor.pnpm run test:vitest ui-codemods→ that fixture fails.2. Come up with new edge cases the fixtures don't cover