Activate "required plugins" before the tested plugin - #10
Merged
Conversation
meszarosrob
commented
Jul 22, 2026
|
|
||
| public function execute(): void | ||
| { | ||
| $testedPluginName = Path::getFilenameWithoutExtension($this->packageRootPath->path()); |
Contributor
Author
There was a problem hiding this comment.
note:
This is now done in multiple files https://github.com/search?q=repo%3Ainpsyde%2Fwp-phpunit-integration%20getFilenameWithoutExtension&type=code.
In a future PR, I would like to move this "filename without extension" functionality to some central place, perhaps a service class, rather than doing it in the tasks themselves.
amiut
approved these changes
Jul 24, 2026
Member
There was a problem hiding this comment.
I have tested it on https://github.com/inpsyde/fairyloot-multi-warehouse/pull/66 and it works like a charm 💪, thanks a lot for taking care of it. LGTM.
I left a very minor comment but please feel free to ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the issue reported at #9 where custom code was needed to activate the dependencies in cases where a plugin defined "Requires Plugins".
This PR takes advantage of WP-CLI, which could return the "Requires Plugins" information, as that was the simplest option to retrieve. Alternatives included parsing the header ourselves or including the necessary WP classes and functions to extract the information.
For this reason, the
WpCliclass'srunmethod signature was changed to return the output of WP-CLI. This is not a breaking change.