[wip] feat: adds mainnet chain to constants crate #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanlott
changed the title
dylanlott
changed the title
prestwich
reviewed
Nov 6, 2025
Evalir
force-pushed
the
dylan/mainnet-constants
branch
from
47790e3 to
074fc32
Compare
Evalir
reviewed
Nov 12, 2025
| pub const MAINNET: SignetConstants = SignetConstants::new(MAINNET_SYS, MAINNET_ENV); | ||
|
|
||
| /// The URL of the Transaction Cache endpoint (empty for mainnet placeholder). | ||
| pub const TX_CACHE_URL: &str = "TODO"; |
Member
There was a problem hiding this comment.
The only thing missing is the tx cache url cc @rswanson
Contributor
Author
There was a problem hiding this comment.
@Evalir let's get this updated and moved to review asap 👍
Member
There was a problem hiding this comment.
this was already updated? As long as we're good with the deploy height being unfinalized I'm ok with marking this as rfr
Contributor
Author
There was a problem hiding this comment.
Ah, didn't realize it had been pushed up. Will get you the finalized deploy height number and we can move this to review 👍
Member
|
deploy height is potentially not finalized |
Evalir
force-pushed
the
dylan/mainnet-constants
branch
from
074fc32 to
fc02bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[wip] feat: adds mainnet chain to constants crate
This PR adds mainnet values to the constants crate in preparation for mainnet deployment.
Closes ENG-1339