Fix cpnet_getHostByName return value on error#38
Merged
guillerodriguez merged 1 commit intomasterfrom Feb 13, 2026
Merged
Conversation
In platforms lacking gethostbyname_r, such as Darwin (macOS), cpnet_getHostByName incorrectly returns -errno when gethostbyname fails. It should return -h_errno instead. Since errno is not set by gethostbyname, the value returned by cpnet_getHostByName is undefined at that point. It could be 0 or a stale value from a previous unrelated system call. If cpnet_getHostByName returns 0 (CPNATIVE_OK) the caller (Java_java_net_VMInetAddress_getHostByName) then proceeds to access the addresses pointer, which was never initialized, typically leading to a crash (SIGBUS/SIGSEGV). Fix by returning -h_errno on error. Fixes #37 (BZ#124082) Signed-off-by: Guillermo Rodríguez <grodriguez@ingelabs.com>
avazquezdev
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In platforms lacking gethostbyname_r, such as Darwin (macOS), cpnet_getHostByName incorrectly returns -errno when gethostbyname fails. It should return -h_errno instead.
Since errno is not set by gethostbyname, the value returned by cpnet_getHostByName is undefined at that point. It could be 0 or a stale value from a previous unrelated system call.
If cpnet_getHostByName returns 0 (CPNATIVE_OK) the caller (Java_java_net_VMInetAddress_getHostByName) then proceeds to access the addresses pointer, which was never initialized, typically leading to a crash (SIGBUS/SIGSEGV).
Fix by returning -h_errno on error.
Fixes #37 (BZ#124082)