fix(ui): expand the current section's children in the left nav - #7650
Open
sanderson wants to merge 1 commit into
Open
fix(ui): expand the current section's children in the left nav#7650sanderson wants to merge 1 commit into
sanderson wants to merge 1 commit into
Conversation
The sidebar active-state refactor (ae00008) moved active/open class injection to an inline script that opens the ancestor lists of the active nav item, but dropped the IsMenuCurrent behavior of also opening the active section's own children list. Viewing a section page left its sub-pages collapsed. Open the active item's direct children list and toggle, and add a Cypress test covering both the ancestor-open and self-open behaviors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
📦 PR Preview — Preview Bot
Preview auto-deploys on push. Will be cleaned up when PR closes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar active-state refactor (ae00008) moved active/open class injection to an inline script that opens the ancestor lists of the active nav item, but dropped the IsMenuCurrent behavior of also opening the active section's own children list. Viewing a section page left its sub-pages collapsed.
Open the active item's direct children list and toggle, and add a Cypress test covering both the ancestor-open and self-open behaviors.
Checklist
npx hugo --quiet)