Skip to content

Verify Markdown twins and JSON-LD entity links on every PR - #7614

Open
jstirnaman wants to merge 3 commits into
masterfrom
docs/ai-visibility
Open

Verify Markdown twins and JSON-LD entity links on every PR#7614
jstirnaman wants to merge 3 commits into
masterfrom
docs/ai-visibility

Conversation

@jstirnaman

@jstirnaman jstirnaman commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Adds pr-ai-artifacts-check.yml, a pre-merge gate for the Markdown-twin
    and AI-discovery artifact set.
  • Adds scripts/check-jsonld-links.js (yarn check:jsonld-links) and unit
    tests. It verifies that every JSON-LD @id reference in built HTML
    resolves to a node defined somewhere in the site's entity graph.
  • Documents the check in DOCS-TESTING.md and the docs-testing skill.

Why

CircleCI already generates these artifacts, but not in a form that can gate
a PR. On non-master branches it runs build:md --only-changed and skips
build:llms-full and check:md-coherence entirely, because a partial .md
set would false-positive them. Nothing verified JSON-LD @id references at
all.

The job builds the site because the checks need a complete public/ to run
against. That build is a cost, not the feature.

Impact

  • Blocks merge on missing Markdown twins, incomplete llms-full corpora,
    and dangling JSON-LD @id references.
  • Covers the 234 API-reference twins no other PR check sees:
    pr-render-check builds without API docs, and pr-preview builds them
    but verifies nothing.
  • ~3 minutes, path-filtered to content, layouts, data, API specs, and the
    scripts that generate the artifacts.

Verification

CI run on this PR: 4447 URLs in sitemap-md.xml, 15 corpora coherent,
markdown-completeness 2/2, JSON-LD 18 nodes across 6195 HTML pages.

Locally:

  • yarn test:jsonld-links
  • yarn check:jsonld-links --public-dir public
  • yarn check:md-coherence --public-dir public
  • PUBLIC_DIR=public yarn test:markdown-completeness

Preview pages

Not applicable — CI and build-validation changes only.

Checklist

  • Signed the InfluxData CLA (if necessary)
  • Rebased/mergeable
  • Local build passes

@jstirnaman
jstirnaman requested a balanced review from Copilot August 5, 2026 21:58
@jstirnaman
jstirnaman requested a review from a team as a code owner August 5, 2026 21:58
@jstirnaman
jstirnaman requested review from sanderson and removed request for a team August 5, 2026 21:58
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Vale Style Check Results

Metric Count
Errors 0
Warnings 0

Check passed

@jstirnaman
jstirnaman removed the request for review from sanderson August 5, 2026 22:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI validation for AI discovery artifacts, Markdown twins, and JSON-LD entity links.

Changes:

  • Adds a full-build PR workflow for AI artifacts.
  • Adds JSON-LD link validation and tests.
  • Documents AI visibility architecture and review guidance.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/pr-ai-artifacts-check.yml Adds AI artifact CI validation.
.agents/skills/ai-visibility/SKILL.md Adds AI visibility review guidance.
DOCS-AI-VISIBILITY.md Documents AI discovery surfaces.
DOCS-TESTING.md Lists the new CI check.
scripts/check-jsonld-links.js Validates JSON-LD references.
scripts/__tests__/check-jsonld-links.test.mjs Tests JSON-LD validation.

- 'scripts/check-jsonld-links.js'
- 'scripts/check-md-alternate-coherence.js'
- 'scripts/lib/**'
- 'scripts/rust-markdown-converter/**'
jstirnaman added a commit that referenced this pull request Aug 5, 2026
- Register check-jsonld-links.js as `yarn check:jsonld-links` so it
  matches every sibling build/check script and is runnable locally.
- Add `yarn test:jsonld-links` and run it in the workflow. The unit test
  was not referenced by any script or workflow, so it never executed.
- Document why this workflow builds the site instead of reusing the
  CircleCI build or the pr-render-check job, and warn against switching
  `build:md` to `--only-changed` (which would gut the checks).
- Add a concurrency group so rapid pushes cannot stack full site builds.
- Add timeout-minutes and list the two test files in the path filter.
- List the workflow in the docs-testing skill CI table.
- Register check-jsonld-links.js as `yarn check:jsonld-links` so it
  matches every sibling build/check script and is runnable locally.
- Add `yarn test:jsonld-links` and run it in the workflow. The unit test
  was not referenced by any script or workflow, so it never executed.
- Document why this workflow builds the site instead of reusing the
  CircleCI build or the pr-render-check job, and warn against switching
  `build:md` to `--only-changed` (which would gut the checks).
- Add a concurrency group so rapid pushes cannot stack full site builds.
- Add timeout-minutes and list the two test files in the path filter.
- List the workflow in the docs-testing skill CI table.
@jstirnaman jstirnaman changed the title Adds a PR workflow that builds API docs and the Hugo site Verify Markdown twins and JSON-LD entity links on every PR Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants