[FIX] [IPv6] Use correct destination address so packets with multicast destination are properly handled#1104
Closed
mgonzalezlopezudc wants to merge 3 commits into
Closed
Conversation
…t destination are properly handled
avarga
added a commit
that referenced
this pull request
Jun 4, 2026
…cast packets Merged from inet-framework/inet PR #1104 by mgonzalezlopezudc. In datagramLocalOut() and routeMulticastPacket(), IPv6 multicast packets were sent with MacAddress::BROADCAST_ADDRESS as the destination MAC. This is incorrect: RFC 2464 Section 7 specifies that IPv6 multicast addresses should be mapped to Ethernet multicast addresses using Ipv6Address::mapToMulticastMacAddress(). Using broadcast causes all nodes on the link to process the frame at the MAC layer, even if they have not joined the multicast group. Updated fingerprints: multicast MAC destination address changed from ff:ff:ff:ff:ff:ff to 33:33:xx:xx:xx:xx, affecting byte-level content fingerprints in all IPv6 simulations that use multicast (ND, EIGRP, etc).
Member
|
Part of |
Member
|
Thanks for this fix, @mgonzalezlopezudc — the diagnosis is spot on. IPv6 multicast datagrams were being handed to the link layer with the broadcast MAC instead of the proper
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version was inefficient because it used the broadcast address as the destination address for any multicast packet.