Parallel pytato PyOpenCL array context#358
Draft
majosm wants to merge 4 commits into
Draft
Conversation
2 tasks
7248dee to
3fed163
Compare
648760a to
cdabe82
Compare
Collaborator
Author
|
@inducer FWIW, I found a workaround for the Intel issues. Seems like the failures are due to buffer overflow, possibly from bad handling of the partially-filled workgroups at the tail ends of loops. Adding some padding at the end via custom allocator makes the failures go away (I tried it on several Intel CL versions, which were previously failing on different tests for each version). It's not an ideal solution, but it avoids having to fiddle with versions or skip tests at least. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PytatoParallelPyOpenCLArrayContext, which is likePytatoPyOpenCLArrayContextbut parallelizes over the device. Based on @kaushikcfd's work in #216. This version generalizes that code to work with fused loops.The basic procedure is:
cc @lukeolson