[KDA] Refactor csrc kernel selection, add tests and sanity check#42
Merged
[KDA] Refactor csrc kernel selection, add tests and sanity check#42
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the SM100 kernel dispatch logic by introducing BOOL_SWITCH and BETA_TYPE_SWITCH macros, which significantly reduces boilerplate code and removes redundant kernel aliases. It also enforces a head dimension of 128 in the Python wrappers and adds bfloat16 support for beta tensors in tests. Review feedback identifies critical bugs in the benchmark utilities where gating tensors were incorrectly cast to bfloat16, which would cause kernel failures. Additionally, there are suggestions to resolve redundant dimension checks and to consider runtime dispatch for the RoundingTF32 parameter.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
🔍 Related Issues
#41
🚀 Pull Request Checklist
Thank you for contributing to cuLA! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
⚡ Performance
Reviewer Notes