Repository navigation
feat(domino): add native export, official mapping and proposal consumer #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+834
−20
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # Formal single-node Domino recipe: training, lambda_base curriculum, held-out | ||
| # backbone/corrected observations and exact recovery. Hyperparameters are a | ||
| # starting point, not a convergence or acceptance claim. | ||
| model: | ||
| target_model_path: ${oc.env:ASPEC_TARGET_MODEL,Qwen/Qwen3-8B} | ||
| native_context_length: 32768 | ||
| trust_remote_code: false | ||
| draft_model_config: aspec/config/domino_qwen3_8b_draft_config.json | ||
| dataset: | ||
| eval_interval: 100 | ||
| eval_micro_batch_size: 1 | ||
| train_data_path: ${oc.env:ASPEC_TRAIN_DATA} | ||
| eval_data_path: ${oc.env:ASPEC_EVAL_DATA} | ||
| chat_template: qwen3-instruct | ||
| prompt_key: conversations | ||
| min_loss_tokens: 32 | ||
| shuffle_dataset: true | ||
| dataset_seed: 42 | ||
| training: | ||
| attention_backend: flex_attention | ||
| draft_context_parallel_size: 1 | ||
| micro_batch_size: 1 | ||
| draft_accumulation_steps: 2 | ||
| learning_rate: 6e-4 | ||
| min_lr: 6e-5 | ||
| weight_decay: 0.0 | ||
| max_grad_norm: 1.0 | ||
| max_seq_length: 4096 | ||
| num_epochs: 3 | ||
| warmup_ratio: 0.04 | ||
| seed: 42 | ||
| continual_training: false | ||
| deterministic_anchor_sampling: false | ||
| training_num_gpus_per_node: 2 | ||
| training_num_nodes: 1 | ||
| placement_strategy: inference_first | ||
| fsdp_strategy: REPLICATE | ||
| fsdp_reduce_dtype: bfloat16 | ||
| compile_model: false | ||
| max_concurrent_batches: 1 | ||
| streaming_dispatch_with_training: true | ||
| pipeline_dispatch_with_training: true | ||
| prefetch_depth: 1 | ||
| save_interval: 100 | ||
| save_per_epoch: false | ||
| save_final_checkpoint: true | ||
| max_checkpoints: 2 | ||
| dflash_block_size: 16 | ||
| dflash_packing: false | ||
| dflash_num_target_layers: 5 | ||
| dflash_num_anchors: 128 | ||
| dflash_loss_objective: decay | ||
| dflash_loss_decay_gamma: 7.0 | ||
| dflash_ce_loss_alpha: 1.0 | ||
| dflash_l1_loss_alpha: 0.0 | ||
| domino_lambda_base: 0.3 | ||
| domino_lambda_base_start: 1.0 | ||
| domino_lambda_base_decay_ratio: 1.0 | ||
| domino_eval_backbone: true | ||
| inference: | ||
| inference_engine_type: sgl | ||
| store_last_hidden_states: false | ||
| target_prefill_memory_optimized: false | ||
| inference_num_gpus: 1 | ||
| inference_num_gpus_per_engine: 1 | ||
| inference_num_gpus_per_node: 3 | ||
| inference_fetch_batch: 8 | ||
| inference_buffer_threshold: 2 | ||
| max_sample_pool_size: 12 | ||
| inference_batch_size: 2 | ||
| sglang: | ||
| tp_size: 1 | ||
| mem_fraction_static: 0.5 | ||
| mooncake: | ||
| master_server_address: null | ||
| metadata_server: null | ||
| data_plane: store | ||
| protocol: tcp | ||
| enable_gpu_direct: false | ||
| allow_host_fallback: false | ||
| global_segment_size: 32GB | ||
| local_buffer_size: 8GB | ||
| host_buffer_size: 1GB | ||
| async_put_pool_size: 1 | ||
| enable_hard_pin: true | ||
| max_seq_len: 4096 | ||
| hidden_dim: 4096 | ||
| logging: | ||
| report_to: none | ||
| debug: | ||
| enable_perf_metrics: true | ||
| output_dir: outputs/domino-qwen3-8b | ||
| cache_dir: cache/domino-qwen3-8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use the same CPU attention mask here that Domino uses during training? The plain
DFlashModelwrapper skips the dense mask for this block on CPU, so the draft can attend to the anchor's target feature and the zero-padded rows. Those rows still count in the softmax. The test builds its reference with this same backbone, so it would agree either way. One small check I'd love to see for both label layouts: keep the token IDs fixed, change only the anchor's target feature, and check that the backbone logits stay the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a4f9b1a:
DominoConsumernow enables_materialize_cpu_block_maskand uses the same dense block mask as training. Added a regression for both label layouts that changes only the anchor target feature and asserts the backbone hidden states/logits stay identical.