Skip to content

Fix/security hardening #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imjohnbo merged 2 commits into from
Apr 11, 2026
Merged

Fix/security hardening #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f064b16
chore: ignore .worktrees directory
imjohnbo Apr 11, 2026
4addf57
fix: harden OAuth callback against HTML injection and shell interpola…
imjohnbo Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
node_modules/
.DS_Store
*.log
.worktrees/
spec/v4.new.json
spec/.issue-title.txt
spec/.issue-body.md
7 changes: 4 additions & 3 deletions src/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createHash, randomBytes } from 'node:crypto';
import { createServer } from 'node:http';
import { exec } from 'node:child_process';
import { execFile } from 'node:child_process';
import { setTokens, getOAuthClientId, getRefreshToken, getOAuthRedirectUri } from './config.js';

const REDIRECT_PORT = 9876;
Expand All @@ -26,7 +26,7 @@ function openBrowser(url) {
process.platform === 'win32' ? 'start' :
process.platform === 'darwin' ? 'open' :
'xdg-open';
exec(`${cmd} "${url}"`);
execFile(cmd, [url]);
}

function waitForCallback() {
Expand All @@ -42,8 +42,9 @@ function waitForCallback() {
server.close();
resolve(code);
} else {
const safeError = (error || 'Unknown error').replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
res.writeHead(400, { 'Content-Type': 'text/html' });
res.end(`<html><body style="font-family:sans-serif;padding:2rem"><h2>Authorization failed</h2><p>${error || 'Unknown error'}</p></body></html>`);
res.end(`<html><body style="font-family:sans-serif;padding:2rem"><h2>Authorization failed</h2><p>${safeError}</p></body></html>`);
server.close();
reject(new Error(`Authorization failed: ${error || 'unknown error'}`));
}
Expand Down
Loading