Skip to content

Unexpected behaviors in omerotools: parse_url and upload_image_to_omero #154

Description

@loicsauteur

Hi all

while testing your OMERO_batch_projection.py script I noticed:

parse_url:

  1. Lines 113-117 should be removed (they do not do anything)

image_ids = (
[s.split("%")[0].replace("|", "") for s in omero_str.split("image-")[1:]]
if "image-" in omero_str
else omero_str.split(",")
)

  1. Does not work with plain dataset ID. Running on dataset IDs results in an error.This would require checking if the supplied ID (e.g. 12345) is a Dataset, Project, or Image.

upload_image_to_omero:

It would be nice if it would check if the path exists and if not: raise a FileNotFoundError.

I can do a PR if you like, let me know!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingchangelogNeeds to be mentioned in release changelogsenhancementNew feature or request

Type

Projects

  • Status
    In progress

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions