Repository navigation
fix(desktop): keep a background review from touching a new course or a used roadmap - #284
Merged
Merged
Conversation
…a used roadmap A review's save makes its course active, so researching a new course now stops the last draft's review first. No review starts once the learner has edited or approved the draft, and once a review's agent survives its cancel every later edit and Approve is refused, not just the first.
…ong as before the background review The mock finished research after two reads once the review moved to the background, so the accessibility e2e sometimes missed the research screen on a slow runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #279, from a review after it merged.
Problems
save_roadmapmakes its course active (coresaveRoadmap,activatedefaults to true). A learner who left a fresh roadmap untouched and researched a new course could have the old draft's review save afterwards and make the old course active again. The new research then failed its done check or showed the old roadmap.running, so the next edit or Approve saved, and the agent could still overwrite an approved course.Fixes
saveConceptsremembers courses whose review couldn't be stopped and refuses every later save of them.Verified
npm run typecheckand the full desktop suite indesktop/: 1112 passed, 11 skipped.