Repository navigation
test(desktop): wait for the sidebar's job list before focusing its job - #283
Merged
Merged
Conversation
On a slow macOS runner the list could land a moment after the progress event, so the test read null and failed (seen on #282).
…laky read on a loaded run
…s on a busy runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar focus test read the job list right after the progress event. On a slow macOS runner the list can land a moment later, so it read null and failed on #282, a version-only change. It now waits for the list with
findByRole.Verified: the test file passed 5 runs locally, and the same test passed 10 of 10 runs before the change, so the failure was timing on CI, not the app.