Fix bytesplice#191
Merged
Merged
Conversation
…haracters, requires the string to be encoded as binary, otherwise it'll raise a range error most of the strings passed to #read_str come from downstream usage of itself, so there are more chances of reducing string creation by returning binary strings
HoneyryderChuck
force-pushed
the
fix-bytesplice
branch
from
3bc1328 to
dc550fb
Compare
Collaborator
Author
|
@igrigorik can you go to "Settings" -> "Actions" -> "General" and enable " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix String#bytesplice usage, which in order to be able to cut UTF-8 characters, requires the string to be encoded as binary, otherwise it'll raise a range error.
most of the strings passed to #read_str come from downstream usage of itself, so there are more chances of reducing string creation by returning binary strings.