BE | Docs + CHANGELOG for shipped container isolation (#91) - #98
Conversation
|
Warning Review limit reached
Next review available in: 9 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ce40fe0 to
80cb050
Compare
0932676 to
488df3b
Compare
80cb050 to
2693d58
Compare
488df3b to
afadfae
Compare
Prefer versioned evaluator-sandbox image when Docker is available, build only if the image is missing, and leave container_id nil when Docker is unavailable so host execution stays fail-closed. Align rake docker:build with image_ref/latest tags (Closes #88).
Summary Opt-in live Docker tests behind SKILL_BENCH_DOCKER_TESTS=1 Skip cleanly without flag or without daemon (default CI unit path) Assert RunCommand works with a real container_id and container is cleaned up after Sandbox.run Closes #89 Stacked on #95 / #88. Test plan Without env flag: 2 skips With Docker + flag: live tests pass (CI job in BE | CI job for container integration #90) CI unit matrix still green (skips)
fetch_config used || so options with api_key: nil fell through to SkillBench::Config.for_provider, making validate-key checks and clients inherit polluted/global keys (flaky CI on ValidateCommandTest). Prefer key presence including explicit nil. Harden validate test Config.reset.
Run docker:build and SKILL_BENCH_DOCKER_TESTS=1 suite on ubuntu-latest without changing the hermetic Ruby matrix. Open pull_request triggers so stacked feature-base PRs also receive CI (Closes #90).
2693d58 to
dcc322a
Compare
Flip README threat-model language from planned to shipped-when-Docker-available, add CHANGELOG Security entry, and link architecture.md to docs/docker.md (Closes #91).
afadfae to
522c78d
Compare
1 participant
Summary
Closes #91
Top of stack — after #97 / #90.