Skip to content

BE | Live Docker integration tests (opt-in) (#89) - #96

Merged
igmarin merged 9 commits into
feat/issue-88-activate-lifecyclefrom
feat/issue-89-live-docker-tests
Aug 8, 2026
Merged

BE | Live Docker integration tests (opt-in) (#89)#96
igmarin merged 9 commits into
feat/issue-88-activate-lifecyclefrom
feat/issue-89-live-docker-tests

Conversation

@igmarin

@igmarin igmarin commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary

  • Opt-in live Docker tests behind SKILL_BENCH_DOCKER_TESTS=1
  • Skip cleanly without flag or without daemon (default CI unit path)
  • Assert RunCommand works with a real container_id and container is cleaned up after Sandbox.run

Closes #89

Stacked on #95 / #88.

Test plan

igmarin added 6 commits August 7, 2026 21:42
@igmarin
Package Docker build context for container isolation
80e9605 
Ship execution/docker with a minimal Dockerfile and include it in the
gemspec so gem installs can activate Sandbox isolation. Point Sandbox
and PackageVerifier at the shared docker context path, with packaging
tests as the gate (Closes #86).
@igmarin
Fix CI rubocop and package .dockerignore explicitly
15ce797 
Normalize gemspec spacing for RuboCop, ship docker/.dockerignore
(Dir globs skip dotfiles), require it in PackageVerifier, and tighten
the packaging test keep-alive CMD assertion from CodeRabbit feedback.
@igmarin
Define evaluator-sandbox image contract and docker:build
de14399 
Document the MVP image contract, align the Dockerfile comments with
runtime network-none isolation, add rake docker:build to tag
evaluator-sandbox with the gem version and latest, and cover the
contract with unit tests (Closes #87).
@igmarin
Fix RuboCop trailing blank line in Rakefile
996bbce 
CI failed on Layout/TrailingEmptyLines for the docker:build task block.
@igmarin
Activate Docker container lifecycle with skip-rebuild
2daad4b 
Prefer versioned evaluator-sandbox image when Docker is available,
build only if the image is missing, and leave container_id nil when
Docker is unavailable so host execution stays fail-closed. Align rake
docker:build with image_ref/latest tags (Closes #88).
@igmarin
Add opt-in live Docker integration tests
e1344bd 
Skip unless SKILL_BENCH_DOCKER_TESTS=1 and a Docker daemon is available.
Prove RunCommand through a real container_id and that the container is
cleaned up after Sandbox.run (Closes #89).
@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a65ee78c-fb55-4616-bac0-89d559d80854

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@igmarin igmarin mentioned this pull request Aug 8, 2026
Merged
@igmarin
igmarin force-pushed the feat/issue-88-activate-lifecycle branch 2 times, most recently from 85c78a8 to 137d6af Compare August 8, 2026 15:27
@igmarin
igmarin merged commit 34924c8 into feat/issue-88-activate-lifecycle Aug 8, 2026
3 checks passed
@igmarin
igmarin deleted the feat/issue-89-live-docker-tests branch August 8, 2026 15:32
igmarin added a commit that referenced this pull request Aug 8, 2026
@igmarin
BE | CI job for container integration (#90) (#97)
dbce369 
Summary
Add container-integration job: build image + live Docker tests
Keep existing Ruby matrix hermetic (no Docker required for unit path)
Open pull_request triggers so stacked PRs (non-main bases) still get CI
Closes #90

Stacked on #96 / #89.
@igmarin igmarin mentioned this pull request Aug 8, 2026
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@igmarin