Repository navigation
Build the repo with the published ICSharpCode.ReferenceAssemblyAnnotator - #2
Merged
Merged
Conversation
Replace TunnelVisionLabs.ReferenceAssemblyAnnotator 1.0.0-alpha.160 (which still has the GetElementType() comparer bug) with the published ICSharpCode.ReferenceAssemblyAnnotator 2.0.0-preview.7. The project now references a package with its own ID, which fails restore with NU1108, so restore the NewIdRequiredDueToNuGetBug PackageId workaround under the new ID. The packed nupkg keeps its real name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up 1 from #1: the repo annotated its own references with the old
TunnelVisionLabs.ReferenceAssemblyAnnotator1.0.0-alpha.160, which still has theGetElementType()comparer bug. It now uses the publishedICSharpCode.ReferenceAssemblyAnnotator2.0.0-preview.7.Directory.Build.props: the package reference now points toICSharpCode.ReferenceAssemblyAnnotator2.0.0-preview.7.ICSharpCode.ReferenceAssemblyAnnotator.csproj: the project now references a package with its own ID, so restore fails withNU1108: Cycle detected. This brings back theNewIdRequiredDueToNuGetBugworkaround that Port to .NET 10 SDK, rename to ICSharpCode.ReferenceAssemblyAnnotator, add GitHub Actions #1 removed, with the new ID: during restorePackageIdisICSharpCode.ReferenceAssemblyAnnotator.NewIdRequiredDueToNuGetBug, and theRestorePackageIdtarget sets it back before the nuspec is generated. The nupkg is stillICSharpCode.ReferenceAssemblyAnnotator.<version>.nupkg.CLAUDE.md: updated the note about which package the repo builds itself with, and explained the workaround.Validation
dotnet build -c Release: clean, no warnings.project.assets.jsonlists onlyICSharpCode.ReferenceAssemblyAnnotator/2.0.0-preview.7and no TunnelVisionLabs package; it annotated 113 reference assemblies.msbuild.exe -restoreof the solution: clean.build/test.ps1 -Engine dotnet: all 17 test builds passed. Themsbuildengine was not run locally; CI covers it.🤖 Generated with Claude Code