Issue #3921 : preserve delegate construction - #4126
Open
marcusmalloc wants to merge 3 commits into
Open
Conversation
siegfriedpammer
force-pushed
the
master
branch
from
September 9, 2026 06:31
6f36d8b to
701df21
Compare
| if (conversion.Conversion.Method.IsStatic | ||
| && conversion.Conversion.Method is not LocalFunctionMethod { IsStaticLocalFunction: false } | ||
| && conversion.Conversion.Method.Parameters.Count == type.GetDelegateInvokeMethod()?.Parameters.Count | ||
| && expressionBuilder.settings.GetMinimumRequiredVersion() >= LanguageVersion.CSharp11_0 |
Member
There was a problem hiding this comment.
That's an interesting way of using GetMinimumRequiredVersion... I'd prefer to have a separate setting, like with all the other features. Or maybe just omit it.
also patterns would fit nicely here: conversion.Conversion.Method is { IsStatic: true, ... } maybe?
Member
|
Thank you for your contribution... what's the commit message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers #3921
Problem
ILSpy decompiles and returns 'return M' and 'return new Action(M)' as 'return M.'
Solution
As @dgrunwald recommended, this PR adds an ILast instruction to distinguish cached / fresh delegates throughout decompilation.
Please let me know if any changes need to be made to my implementation!